This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add solc as a devDep to compile-solidity-tests
#5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The *compiles w/ local path* test referenced a file in a node_modules folder that was already subject to moving due to lerna hoisting behavior. This uncertainty makes the test unreliable! This PR adds a pinned version of solc as a devDep, ensuring the file will be available for testing purposes using `require.resolve`.
cds-amal
requested review from
gnidan,
eggplantzzz,
fainashalts,
cliffoo and
kevinbluer
eggplantzzz
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The compiles w/ local path test referenced a file in a node_modules folder that was already subject to moving due to lerna hoisting behavior. This uncertainty makes the test unreliable!
This PR adds a pinned version of solc as a devDep, ensuring the file will be available for testing purposes using
require.resolve.Note, we will have to update this pinned version as part of the bump solc chore.
Testing instructions
check out the branch and run the compiles w/ local path test in
compile-solidity-tests, or verify tests don't fail in CIDocumentation
doc-change-requiredlabel to this PR if documentation updates are required.Breaking changes and new features
breaking-changeandnew-featurelabels for the appropriate packages.