Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Update typescript, ttypescript, typedoc #6070

Merged
merged 3 commits into from Jun 5, 2023
Merged

Conversation

cliffoo
Copy link
Contributor

@cliffoo cliffoo commented Jun 5, 2023

Second attempt! I overlooked typedoc warnings the first time so that was reverted.

Update typescript to latest 4.x (4.9.5), ttypescript to latest (1.5.15), typedoc to latest (0.24.8).

Copy link
Contributor

@eggplantzzz eggplantzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it builds it builds I guess!

@haltman-at
Copy link
Contributor

Well, unless it builds with serious documentation warnings. Currently checking that...

@haltman-at
Copy link
Contributor

OK, there are indeed no nasty documentation warnings, hooray!

There are some deprecation warnings emitted by ttsc. I don't know how bad these are. Can anyone (@gnidan?) weigh in?

Specifically, they are:

@truffle/codec: DeprecationWarning: 'updateImportDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.
@truffle/db: DeprecationWarning: 'updateImportDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.
@truffle/db: DeprecationWarning: 'updateImportTypeNode' has been deprecated since v4.6.0. Use the overload that accepts 'assertions'
@truffle/db: DeprecationWarning: 'updateExportDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.
@truffle/db-kit: DeprecationWarning: 'updateImportDeclaration' has been deprecated since v4.8.0. Decorators are no longer supported for this function. Callers should switch to an overload that does not accept a 'decorators' parameter.

...my guess though is that since the tests all pass, these can't be too serious. So what the hell, I'll approve it too.

@cliffoo
Copy link
Contributor Author

cliffoo commented Jun 5, 2023

ok boom

@cliffoo cliffoo merged commit 100dfa9 into develop Jun 5, 2023
10 checks passed
@cliffoo cliffoo deleted the update-type-things branch June 5, 2023 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants