This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Remove the other slow Hardhat test #6114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I think we can probably remove this test as well. These failure conditions should probably just be tested with mocks in the from-hardhat package, rather than booting up all of Hardhat for end-to-end testing. We can probably just do this sort of end-to-end testing for the happy path. |
|
Cool, I'll update this PR to remove the test, then! |
haltman-at
changed the title
gnidan
reviewed
Jun 21, 2023
| }); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
We also need to delete the fixtures, right?
There was a problem hiding this comment.
Oh, good point -- including the one for the other deleted test; I never deleted the fixtures for the other removed test either.
gnidan
approved these changes
Jun 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing this timeout yet again.If this isn't enough to stop the problems, we might want to remove this test as well... (or try increasing the Hardhat version like Nick suggested, which might allow us to add the other test back in? I dunno.)DELETE