This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Ensure CalldataDecodingInspector always passes through inspector options #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This is why you should always used named options for everything all the time ;) |
gnidan
approved these changes
Jul 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
I noticed tonight that the
CalldataDecodingInspectordoesn't actually pass its inspector options through when inspecting intepretations as multicalls or etc. Oops. Changed that to pass that through. Also turned on thenoHideAddressoption in debug-utils, because we always use that option in the debugger.Testing instructions
I'm going to be honest, I didn't really test this one, I wanted to get it up quick...
Breaking changes and new features
Because I changed the argument order of
formatFunctionLike, which is exported, this is technically a breaking change to Codec (and indeed, I had to adjust the use indebug-utilsappropriately).It could be done in a non-breaking way, but that would be ugly. Arguably we should switch from positional params to named params, but that would also be breaking, and frankly I don't think it's worth the effort for something this small.