Have debugger skip anything called from a generated source while stepping

packages/debugger/lib/controller/sagas/index.js

@@ -78,16 +78,20 @@ function* advance(action) {
  */
 function* stepNext() {
   const starting = yield select(controller.current.location);
+  const isStartingGenerated = yield select(
+    controller.current.isAnyFrameGenerated
+  );
   const allowInternal = yield select(controller.stepIntoInternalSources);
 
-  let upcoming, finished;
+  let upcoming, finished, isUpcomingGenerated;
 
   do {
     // advance at least once step
     yield* advance();
 
     // and check the next source range
     upcoming = yield select(controller.current.location);
+    isUpcomingGenerated = yield select(controller.current.isAnyFrameGenerated);
 
     finished = yield select(controller.current.trace.finished);
 
@@ -98,8 +102,8 @@ function* stepNext() {
       //don't stop on an internal source unless allowInternal is on or
       //we started in an internal source
       (!allowInternal &&
-        upcoming.source.internal &&
-        !starting.source.internal) ||
+        (upcoming.source.internal || isUpcomingGenerated) &&
+        !(starting.source.internal || isStartingGenerated)) ||
       upcoming.sourceRange.length === 0 ||
       upcoming.source.id === undefined ||
       (upcoming.node && isDeliberatelySkippedNodeType(upcoming.node)) ||

packages/debugger/lib/controller/selectors/index.js

@@ -7,6 +7,7 @@ import * as Codec from "@truffle/codec";
 
 import evm from "lib/evm/selectors";
 import sourcemapping from "lib/sourcemapping/selectors";
+import stacktrace from "lib/stacktrace/selectors";
 import data from "lib/data/selectors";
 import trace from "lib/trace/selectors";
 
@@ -137,6 +138,24 @@ const controller = createSelectorTree({
       )
     },
 
+    /**
+     * controller.current.callstack
+     */
+    callstack: createLeaf([stacktrace.current.callstack.preupdated], identity),
+
+    /**
+     * controller.current.isAnyFrameGenerated
+     *
+     * This selector checks whether there are any generated sources
+     * stackframes on the callstack.  We should regard ourselves
+     * as still inside a generated source until there are none.
+     * (We only consider generated sources here, not other sorts of internal
+     * sources, to prevent potential problems.)
+     */
+    isAnyFrameGenerated: createLeaf(["./callstack"], callstack =>
+      callstack.some(frame => frame.sourceIsGenerated)
+    ),
+
     /**
      * controller.current.trace
      */

packages/debugger/lib/stacktrace/actions/index.js

@@ -1,11 +1,18 @@
 export const JUMP_IN = "STACKTRACE_JUMP_IN";
-export function jumpIn(location, functionNode, contractNode, sourceIsInternal) {
+export function jumpIn(
+  location,
+  functionNode,
+  contractNode,
+  sourceIsInternal,
+  sourceIsGenerated
+) {
   return {
     type: JUMP_IN,
     location,
     functionNode,
     contractNode,
-    sourceIsInternal
+    sourceIsInternal,
+    sourceIsGenerated
   };
 }
 

packages/debugger/lib/stacktrace/reducers.js

@@ -10,7 +10,13 @@ function callstack(state = [], action) {
   let newFrame;
   switch (action.type) {
     case actions.JUMP_IN:
-      const { location, functionNode, contractNode, sourceIsInternal } = action;
+      const {
+        location,
+        functionNode,
+        contractNode,
+        sourceIsInternal,
+        sourceIsGenerated
+      } = action;
       newFrame = {
         type: "internal",
         calledFromLocation: location,
@@ -27,7 +33,8 @@ function callstack(state = [], action) {
             ? contractNode.name
             : undefined,
         combineWithNextInternal: false,
-        sourceIsInternal
+        sourceIsInternal,
+        sourceIsGenerated
         //note we don't currently account for getters because currently
         //we can't; fallback, receive, constructors, & modifiers also remain
         //unaccounted for at present

packages/debugger/lib/stacktrace/sagas/index.js

@@ -63,12 +63,16 @@ function* stacktraceSaga() {
     const nextLocation = yield select(stacktrace.next.location);
     const nextParent = yield select(stacktrace.next.contractNode);
     const nextSourceIsInternal = yield select(stacktrace.next.sourceIsInternal);
+    const nextSourceIsGenerated = yield select(
+      stacktrace.next.sourceIsGenerated
+    );
     yield put(
       actions.jumpIn(
         currentLocation,
         nextLocation.node,
         nextParent,
-        nextSourceIsInternal
+        nextSourceIsInternal,
+        nextSourceIsGenerated
       )
     );
     positionUpdated = true;

packages/debugger/lib/stacktrace/selectors/index.js

@@ -111,6 +111,15 @@ function createMultistepSelectors(stepSelector) {
       source => source.id === undefined || source.internal
     ),
 
+    /**
+     * .sourceIsGenerated
+     * only specifically generated sources, not unmapped code or anything!
+     */
+    sourceIsGenerated: createLeaf(
+      ["./location/source"],
+      source => source.internal
+    ),
+
     /**
      * .strippedLocation
      */
@@ -156,9 +165,27 @@ let stacktrace = createSelectorTree({
    */
   current: {
     /**
-     * stacktrace.current.callstack
+     * stacktrace.current.callstack (namespace)
      */
-    callstack: createLeaf(["/state"], state => state.proc.callstack),
+    callstack: {
+      /**
+       * stacktrace.current.callstack (selector)
+       */
+      _: createLeaf(["/state"], state => state.proc.callstack),
+
+      /**
+       * stacktrace.current.callstack.preupdated
+       */
+      preupdated: createLeaf(
+        ["./_", "/current/returnCounter"],
+        (callstack, returnCounter) =>
+          popNWhere(
+            callstack,
+            returnCounter,
+            frame => frame.type === "external"
+          )
+      )
+    },
 
     /**
      * stacktrace.current.returnCounter
@@ -398,18 +425,14 @@ let stacktrace = createSelectorTree({
      */
     report: createLeaf(
       [
-        "./callstack",
+        "./callstack/preupdated",
         "./returnCounter",
         "./lastPosition",
         "/current/strippedLocation"
       ],
       (callstack, returnCounter, lastPosition, currentLocation) =>
         generateReport(
-          popNWhere(
-            callstack,
-            returnCounter,
-            frame => frame.type === "external"
-          ),
+          callstack,
           currentLocation || lastPosition,
           null,
           undefined