Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Selector): support Selector selection token #385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ArgoZhang
Copy link

No description provided.

@trullock
Copy link
Owner

trullock commented Mar 2, 2024

Thanks for the PR but you've modified every single line with whitespace changes.

Can you resubmit this with only changes to the affected lines, preserving the whitespace status quo please

@ArgoZhang
Copy link
Author

ArgoZhang commented Mar 2, 2024

@trullock updated

@trullock
Copy link
Owner

trullock commented Mar 4, 2024

Thanks.

Can you add a css test that shows this works?

Add a method to the css bugs cs file, and add the input and expected css files to the test folders.

Should "just work" if you name everything properly

@ArgoZhang
Copy link
Author

@trullock update the unit test for #383

@trullock
Copy link
Owner

Thanks, but its not testing the actual output is correct.

And can you add an additional, more complicated test, I'm not sure the change is going to cope with AND and OR selector rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants