Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut a new release? #178

Closed
joshfng opened this issue Mar 30, 2024 · 7 comments
Closed

Cut a new release? #178

joshfng opened this issue Mar 30, 2024 · 7 comments

Comments

@joshfng
Copy link

joshfng commented Mar 30, 2024

I'm struggling to download a recent release of this repo. The latest commits were 3 months ago, but the latest release on the releases page is from 2022. The readme directs folks to download the github action's artifacts

Now you can also access the latest(and probably unstable) builds from Github Action.

but those have all expired and are no longer available for download

Screenshot 2024-03-30 at 2 35 40 PM

Did I miss something obvious on where I can download the release for the most recent commit? If not, I'd suggest adding another step to your workflow to publish the build artifacts as github releases proper, which will eliminate the CI expiration issue.

Thanks for your time and thanks for all the hard work you all do to enable amd support. Super impressive stuff!

@trulyspinach
Copy link
Owner

Hi @joshfng,

Thanks for reminding me - I also did not realize that the artifacts from Action will expire.

I triggered the pipeline again and pushed the artifacts into a new release(0.7.2), hopefully they will work as they should.
Please give them a try and let me know.

@wirl
Copy link

wirl commented Apr 7, 2024

After updating to 0.7.2 on each start the app says the kext is out of date but I am using both the app and kext from the 0.7.2 release. Am I doing something wrong?

update

@trulyspinach
Copy link
Owner

After updating to 0.7.2 on each start the app says the kext is out of date but I am using both the app and kext from the 0.7.2 release. Am I doing something wrong?

update

Are you sure you are running the latest AMD Power Gadget app?

@wirl
Copy link

wirl commented Apr 7, 2024

I think so, message persists after doing these steps:

[wirl@moo.lan ~/test]$ shasum Artifacts.zip 
e312cc4a445fd2baac4cd0c26e4003630215d71f  Artifacts.zip
[wirl@moo.lan ~/test]$ unzip Artifacts.zip           
Archive:  Artifacts.zip
  inflating: Release.zip             
[wirl@moo.lan ~/test]$ unzip Release.zip  
Archive:  Release.zip
(Removed unzip output)
[wirl@moo.lan ~/test]$ cp -R build/Build/Products/Release/AMDRyzenCPUPowerManagement.kext /Volumes/EFI/EFI/OC/Kexts/AMDRyzenCPUPowerManagement.kext
[wirl@moo.lan ~/test]$ mv "build/Build/Products/Release/AMD Power Gadget.app/" ~/Desktop/.
[wirl@moo.lan ~/test]$ sudo reboot

After rebooting:

[wirl@moo.lan ~]$ kextstat | grep -i spinach
Executing: /usr/bin/kmutil showloaded
No variant specified, falling back to release
   66    0 0xffffff8003fb0000 0x20000    0x20000    wtf.spinach.AMDRyzenCPUPowerManagement (0.7.2) E518DA40-95C5-3294-A0E0-7D831B9A825C <57 18 13 9 7 6 3 2 1>

I have no idea what it could be, not a kextcache issue right because it shows 0.7.2 is running?

@joshfng
Copy link
Author

joshfng commented Apr 7, 2024 via email

@trulyspinach
Copy link
Owner

Thanks, I uploaded a new release, it should've solve the issue. Forgot to update a version string..
Please let me know if the new release fixes the issue!

@wirl
Copy link

wirl commented Apr 8, 2024

Issue has been fixed, thank you! 🙏

@joshfng joshfng closed this as completed Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants