-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WORKFLOW] XY Grid Example #15
Comments
Actually with the recent Even better |
I haven't quite figured out these nodes yet, I'll be experimenting with them. There is not much information on how they work yet |
Just pushed another update to support COMBO. I guess I should stop "small fixes" for now. |
@Trung0246 can you update your workflow here ? When in run the queue, I've got this error:
|
Hm that looks weird. Maybe I could a look when I have time. |
Oh I thought that we are talking about the first one. Maybe Jorge can try again. Yeah the one JLK mentions is the correct connection. |
I can replicate the noodles being detached on load.
|
Oh it just a minor bug as it's related to how I implemented input/output expand stuff. It kinda annoying but hopefully easy to fix when I have time. |
I was trying to make a version of the first workflow, with the Junction Batch nodes. But I can't make new connections. And if I unplug the old ones, they stop working ! For example, if I unplug this Junction Bach node from the Merge node, when I plug it again, the "COMBO" designation is gone, from the output and input connections. But if I connect from the Junction Bach node above, which still has the "COMBO" designation in the output, the connection is successful ( see bottom image ). Is this a bug, or is there another way to make new connections ? |
The problem is COMBO did not actually exist internally but instead it is an array of string which decay to just a single STRING when processed. So that a weird quirk I'm unsure about when I implementing CastReroute and Hub, therefore I decided to leave it as it is. The problem is we wants to retain COMBO type (which is the case for Hub) to make it possible to connect to nodes that are actually expecting that type. Your best bet is convert COMBO to STRING before actually connecting to JunctionBatch then recast to All of this are why CastReroute exist in the first place, which is a tradeoff for being absurdly flexible. |
I'm able to change the output to STRING in the Junction Batch nodes. I'm only able to use the 8 nodes that @bananasss00 connected in his workflow, which already have the output connections as COMBO. If there was a special trick to make this connection, he would probably have explained how to do this, when he shared his workflow, in the first post. Perhaps there is not a trick, and this was working correctly when he made the workflow. |
I guess at one time I added COMBO to CastReroute but later deleted it since it's pointless. Probably have to take a look on how to handle this. Also weird I remembered wildcard Also copy-paste is also iffy so that another bug to the list but honestly I think reverting to Yeah |
I did find a trick to do this ! We can use other nodes with COMBO inputs instead of CastReroute. You could try to add COMBO to CastReroute again, because it's a more elegant solution. But, if you can make the [ * ] connections work correctly, it would be even better, because then we could copy / paste your nodes, and use them as templates. Now, if the connection is [ * ], it gives this error:
|
xy_grid.json
With your nodes you can make grids of any complexity, though not as convenient. But thanks anyway :)
The text was updated successfully, but these errors were encountered: