Skip to content

Commit

Permalink
Remove RTC
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Feb 4, 2024
1 parent 741c38f commit 0905c31
Show file tree
Hide file tree
Showing 10 changed files with 2,503 additions and 2,142 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: 3.10
- name: Install the dependencies
run: |
python -m pip install -U pip setuptools jupyterlab~=3.3 jupyterlite
python -m pip install -U pip setuptools jupyterlab~=4.0 jupyterlite
python -m pip install -e .
jupyter labextension develop . --overwrite
- name: Build the JupyterLite site
Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,10 @@ Powered by Kitware's `vtk.js` and `itk-wasm` library, **jupyterview** is a pure

![pvd](https://user-images.githubusercontent.com/4451292/157324587-0b89159d-f4db-4227-b58b-437c75f69855.gif)

- Visualize mesh supported by `meshio` library. Full list of supported formats is available at https://github.com/nschloe/meshio
- Visualize mesh supported by `meshio` library. Full list of supported formats is available at https://github.com/nschloe/meshio. To open `med` files, `h5py` need to be installed.

https://user-images.githubusercontent.com/4451292/173418573-1839d689-763f-42ba-add3-4eaac4c87d7e.mp4

- Real-time collaborative visualization.

![colab](https://user-images.githubusercontent.com/4451292/157325576-c79c9ee8-6428-4e96-afa6-827467e70438.gif)

- Multiple display modes: `Surface`, `Surface with Edge`, `Wireframe` and `Points`
- Color scale and isocolor effet.
- Warp by scalar effet.
Expand Down
6 changes: 3 additions & 3 deletions binder/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ channels:

dependencies:
# runtime dependencies
- python >=3.8,<3.9.0a0
- jupyterlab >=3,<4.0.0a0
- python >=3.10,<3.11
- jupyterlab >=4,<5
# labextension build dependencies
- nodejs >=14,<15
- nodejs >=18,<19
- pip
- wheel
# additional packages for demos
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"dependencies": {
"@emotion/react": "^11.7.1",
"@emotion/styled": "^11.6.0",
"@jupyter/docprovider": "^1.0.0-alpha.8",
"@jupyter/ydoc": "^1.0.2",
"@jupyterlab/application": "^4.0.0",
"@jupyterlab/coreutils": "^6.0.0",
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ classifiers = [

dependencies = [
"meshio",
"jupyter_server>=1.21,<3",
"jupyter_collaboration>=1.0.0a8",
"jupyter_server>=1.21,<3"
]

dynamic = ["version", "description", "authors", "urls", "keywords"]
Expand Down
9 changes: 2 additions & 7 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ import {
JupyterFrontEndPlugin
} from '@jupyterlab/application';
import { IThemeManager } from '@jupyterlab/apputils';
import {
ICollaborativeDrive
// SharedDocumentFactory
} from '@jupyter/docprovider';
import { KernelExecutor } from './kernel';
import {
JupyterViewModelFactory,
Expand All @@ -30,8 +26,7 @@ const activate = (
app: JupyterFrontEnd,
restorer: ILayoutRestorer,
themeManager: IThemeManager,
shell: ILabShell,
drive: ICollaborativeDrive
shell: ILabShell
): IVtkTracker => {
const tracker = new VtkTracker({ namespace: NAME_SPACE });

Expand Down Expand Up @@ -124,7 +119,7 @@ const activate = (
const plugin: JupyterFrontEndPlugin<IVtkTracker> = {
id: 'jupyterview:plugin',
autoStart: true,
requires: [ILayoutRestorer, IThemeManager, ILabShell, ICollaborativeDrive],
requires: [ILayoutRestorer, IThemeManager, ILabShell],
provides: IJupyterViewDocTracker,
activate
};
Expand Down
2 changes: 1 addition & 1 deletion src/mainview/mainview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ export class MainView extends React.Component<IProps, IStates> {
const interactor = this._renderWindow.getInteractor();
interactor.requestAnimation(this._renderWindow);
let count = 0;
let intervalId: NodeJS.Timer;
let intervalId: any = undefined;
const rotate = () => {
if (count < 90) {
count += ROTATION_STEP;
Expand Down
2 changes: 1 addition & 1 deletion src/mainview/model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export class JupyterViewModel implements DocumentRegistry.IModel {
this._sharedModel.awareness.on('change', this._onCameraChanged);
}

readonly collaborative = true;
readonly collaborative = false;

get sharedModel(): JupyterViewDoc {
return this._sharedModel;
Expand Down
2 changes: 1 addition & 1 deletion src/tools.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export function moveCamera(
const now = performance.now().toString();
const animationRequester = `moveCamera.${now}`;
interactor.requestAnimation(animationRequester);
let intervalId: NodeJS.Timer;
let intervalId: any = undefined;
const consumeAnimationStack = () => {
if (animationStack.length) {
const {
Expand Down
Loading

0 comments on commit 0905c31

Please sign in to comment.