Handle version directly in release action #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💊 0 quarantined ✅ 10 passed 🕐 10 new ⋅ (learn more) |
gnalh
force-pushed
the
gabe/move-version-into-release
branch
from
8087030
to
347ae71
Compare
riya-n
approved these changes
Mar 28, 2024
riya-n
reviewed
Mar 28, 2024
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "trunk-analytics-cli" | |||
| edition = "2021" | |||
| version = "0.5.2" | |||
| version = "0.0.0" | |||
There was a problem hiding this comment.
will we need to update the uploader accordingly?
There was a problem hiding this comment.
No, the version is overwritten by the action on release.
gnalh
commented
Mar 28, 2024
Comment on lines
+25
to
+29
| - name: Update version | ||
| run: | | ||
| export VERSION=${{ github.event.inputs.release_tag }} | ||
| sed -i "s/0.0.0/$VERSION/g" Cargo.toml | ||
|
|
There was a problem hiding this comment.
This is where the magic happens. It overwrites the release version with the one tagged by the pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few instances where we forgot to update the release version. Let's just handle it entirely in the release and leave local as
0.0.0.