New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #44

Merged

gnalh merged 3 commits into main from gabe/update-error-handling

Mar 28, 2024

Contributor

gnalh commented Mar 27, 2024 •

edited

Loading

We should always either return exit_success or the underlying exit code. We should not obfuscate it when an unhandled exception occurs.


          init

0dc5d8e

trunk-staging-io bot commented Mar 27, 2024 •

edited

Loading

💊 0 quarantined ✅ 10 passed 🕐 10 new ⋅ (learn more)

_{docs ⋅ learn more about trunk.io}

gnalh marked this pull request as ready for review

March 27, 2024 20:07

gnalh requested review from federicoweber and riya-n

March 27, 2024 20:07

federicoweber approved these changes

View reviewed changes

zaycev reviewed

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

zaycev reviewed

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

zaycev reviewed

View reviewed changes

src/runner.rs Show resolved Hide resolved

zaycev reviewed

View reviewed changes

src/runner.rs Show resolved Hide resolved

zaycev reviewed

View reviewed changes

src/runner.rs Show resolved Hide resolved

zaycev approved these changes

View reviewed changes

Collaborator

zaycev left a comment

LGTM, I would just make sure we are not missing important information when error occurs.

riya-n approved these changes

View reviewed changes

gnalh added 2 commits

March 28, 2024 16:31


          comments


          Merge branch 'main' into gabe/update-error-handling

24821b4

gnalh merged commit aaf8163 into main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment