Added tfsec as a security linter #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxlijin
reviewed
Mar 10, 2023
|
Re: package-lock.json: I'm not sure - when I initially made the PR, CI told me to run npm install, and I did and pushed the result. I don't know what the implications of that are. Re: .json -> .out.json: tfsec runs on terraform files, which are |
sxlijin
approved these changes
Mar 10, 2023
| @@ -453,7 +453,7 @@ export class TrunkDriver { | |||
| */ | |||
| async runCheckUnit(targetRelativePath: string, linter: string): Promise<TestResult> { | |||
| const targetAbsPath = path.resolve(this.sandboxPath ?? "", targetRelativePath); | |||
| const resultJsonPath = `${targetAbsPath}.json`; | |||
| const resultJsonPath = `${targetAbsPath}.out.json`; | |||
There was a problem hiding this comment.
add comment here explaining the tf.json thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tfsec as a security linter. Includes a small fix to testing that prevents accidentally linting the json output of trunk check.