Add gofumpt #210
Merged
Add gofumpt #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJang27
approved these changes
Mar 16, 2023
Comment on lines
+3
to
+4
| // gofumpt generates a failure on an empty file | ||
| linterCheckTest({ linterName: "gofumpt", namedTestPrefixes: ["empty"] }); |
There was a problem hiding this comment.
Thanks for calling this out. We may move in the future to adding allow_empty_files: false to both gofumpt and gofmt, but this should be fine for now.
package-lock.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "plugins", | |||
| "name": "trunk-plugins", | |||
There was a problem hiding this comment.
Can you back this file change out? Was there something you ran into that brought this up?
There was a problem hiding this comment.
nothing specific, must have happened since I renamed my fork as trunk-plugins
|
@TylerJang27 should be all good to go! |
|
@tomlazar Thanks again! We probably won't get another release out for a week or so, but if you need plugins:
sources:
- id: trunk
ref: 19526b8797860900fb9680233943072b78c9f356
uri: https://github.com/trunk-io/pluginsor you can add your linter definition directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as gofmt, just a little more strict.