Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python-interface as a file type #292

Merged
merged 4 commits into from
May 30, 2023
Merged

add python-interface as a file type #292

merged 4 commits into from
May 30, 2023

Conversation

Ryang20718
Copy link
Contributor

@Ryang20718 Ryang20718 commented May 24, 2023 •
edited

Add .pyi file extension as a file type. Contents should python interfaces/stubs.

Could also add under "python" since contents should just be python, but not sure if that's kosher.

@Ryang20718
add python-interface as a file type
d134a72 
Signed-off-by: ryan <ryang@waabi.ai>
sxlijin
sxlijin reviewed May 25, 2023
View reviewed changes
linters/plugin.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should also be able to update linters/mypy/plugin.yaml and add python-interface to the list of supported filetypes there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

laurit17
laurit17 reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@laurit17 laurit17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you also add comments: -hash like for python.

@Ryang20718
Copy link
Contributor Author

Added. @laurit17 wondering why is the comments: -hash needed? Locally it worked without that?

@TylerJang27
Copy link
Collaborator

TylerJang27 commented May 30, 2023 •
edited

Added. @laurit17 wondering why is the comments: -hash needed? Locally it worked without that?

Hi @Ryang20718. It's primarily necessary for some other functionality within trunk, specifically, supporting trunk-ignore.

@TylerJang27 TylerJang27 merged commit 51e060e into trunk-io:main May 30, 2023
8 checks passed
@TylerJang27
Copy link
Collaborator

Thanks for the contribution! Note that you'll need to point your trunk.yaml plugin ref to 51e060ebfe5e19723265f83f715d95045a2916b4 in the short term until our next plugins release in order for your changes to take effect

@Ryang20718 Ryang20718 deleted the add_pyi_file branch May 30, 2023 19:01
@Ryang20718
Copy link
Contributor Author

Thanks Tyler for helping merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxlijin sxlijin sxlijin left review comments

@laurit17 laurit17 laurit17 left review comments

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ryang20718 @TylerJang27 @sxlijin @laurit17