Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix biome fmt error case #772

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix biome fmt error case #772

merged 1 commit into from
May 7, 2024

Conversation

TylerJang27
Copy link
Collaborator

Fixes #771 for cases of malformed config. biome fmt outputs an exit code of 1. For lint, we have to have success_codes: [0, 1], but for format we can just have success_codes: [0] so that we better surface this error to users.

Also adds a relevant test case.

Copy link

trunk-io bot commented May 7, 2024

⏱️ 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 4m 🟩
Linter Tests ubuntu-latest 3m 🟩
Linter Tests macOS 3m 🟩
CodeQL-Build 2m 🟩
Trunk Check runner [linux] 1m 🟩
Repo Tests / Plugin Tests 40s 🟩
Aggregate Test Results 4s 🟩
Detect changed files 4s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review May 7, 2024 17:19
@TylerJang27 TylerJang27 requested a review from det May 7, 2024 17:19
@TylerJang27 TylerJang27 merged commit 7e2d554 into main May 7, 2024
14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/fix-biome-fmt branch May 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

trunk fmt does not surface biome format errors
2 participants