Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checkout submodules when checking out repo #177

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: checkout submodules when checking out repo #177

merged 2 commits into from
Aug 15, 2023

Conversation

puzzler7
Copy link
Contributor

No description provided.

@puzzler7 puzzler7 requested a review from sxlijin August 14, 2023 04:34
@pat-trunk-io
Copy link
Contributor

submodules:
description: >
Whether to checkout submodules: true to checkout submodules or recursive to
recursively checkout submodules.

I would set to recursive

pat-trunk-io
pat-trunk-io approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@pat-trunk-io pat-trunk-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@puzzler7 puzzler7 merged commit c1d07ab into main Aug 15, 2023
37 checks passed
@puzzler7 puzzler7 deleted the maverick/checkout-submodules branch August 15, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat-trunk-io pat-trunk-io pat-trunk-io approved these changes

@sxlijin sxlijin Awaiting requested review from sxlijin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@puzzler7 @pat-trunk-io