Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile trunk due to "Cannot find type FsEventWatcher in crate notify #11

Closed
Cronnay opened this issue Aug 26, 2020 · 3 comments
Closed

Comments

@Cronnay
Copy link

Cronnay commented Aug 26, 2020

$ cargo --version
cargo 1.45.1 (f242df6ed 2020-07-22)
$ rustup target list
wasm32-unknown-unknown (installed)

Running cargo install trunk gives me this error:
bild

Any clue how I can fix this? Would love to try out Trunk!
Cheers!!

@thedodd
Copy link
Member

thedodd commented Aug 26, 2020

Hey @Cronnay yea, I actually just pushed a fix for this. I was using a type which was platform specific. Just published v0.1.1 which should resolve the issue. I haven't setup CI for this yet to do the cross platform builds. I'll definitely need to do that to account for Windows related issues.

I'll leave this open until I hear back. Let me know if that works for you :)

@Cronnay
Copy link
Author

Cronnay commented Aug 26, 2020

Yes! It works now, cheers! I noticed you made an issue regarding CI/CD. Travis CI is free for open source project, so maybe something relevant for you!

cheers for your help. I'll close this issue

@Cronnay Cronnay closed this as completed Aug 26, 2020
@thedodd
Copy link
Member

thedodd commented Aug 26, 2020

@Cronnay awesome! Glad to hear it.

Yea, I've used Travis quite a lot. I've been really enjoying Github Actions recently as well. Once I have a few spare cycles, I'll probably go with that.

Let me know what you think. Trunk is still a baby project, but hopefully it brings some value. Still lots to be done.

JonasAlaif pushed a commit to JonasAlaif/trunk that referenced this issue Dec 6, 2023
So far, when a cargo project was implicitly configured failing to parse
the Cargo.toml or loading the metadata resulted in the state of
"no rust project found". This is actually wrong, as a project was there,
found, but it metadata could not be evaluated.

This can lead to silent build failures, resulting in broken build
artifacts.

This change only considers the fact that a Cargo.toml is missing as an
indication that this is a non-Rust project. If a Cargo.toml file is
present (or it's presence cannot be evaluated) and it fails to generate
the metadata, it will be considered a build failure.

closes trunk-rs#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants