Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts for building NEXTSPACE from sources #314

Merged
merged 14 commits into from
Aug 4, 2020

Conversation

onflapp
Copy link
Contributor

@onflapp onflapp commented Jul 20, 2020

Useful if you want to build everything from a source on your own.
This should also make it easier to build NEXTSPACE on distros other than RedHat or Debian.

@trunkmaster
Copy link
Owner

trunkmaster commented Jul 21, 2020

Useful if you want to build everything from a source on your own.
This should also make it easier to build NEXTSPACE on distros other than RedHat or Debian.

Are you sure? I see a lot of Debian-specifics (package names, patches, project files used from Packaging/Debian).

@onflapp
Copy link
Contributor Author

onflapp commented Jul 21, 2020

The scripts take the versions and patches from the Debian package definitions
This is to prevent having to maintain it twice.
Patches do not appear to be Debian distribution dependent.
Other than that, it is just cloning the repo, checking out specific branch, applying patches and building the source code.

@trunkmaster do you want me to maintain versions and patches separately from the Debian package definitions?

@trunkmaster
Copy link
Owner

@onflapp you stated "...to build NEXTSPACE on distros other than RedHat or Debian.". And I see Debian specifics instead. Let me reframe my question: "What distros this scripts aimed for? What distros did you test?".

@onflapp
Copy link
Contributor Author

onflapp commented Jul 22, 2020

Good point.

@onflapp
Copy link
Contributor Author

onflapp commented Jul 25, 2020

@trunkmaster I tested it on FreeBSD.
Source preparation scripts all run fine.
Not everything will compile obviously (yet) but that's not point of these scripts.
These scripts should just make it easier to prepare everything in one place without any dependencies to any particular distro and kick off the build process.

Copy link
Owner

@trunkmaster trunkmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Debian specific, custom build of NEXTSPACE. If someone needs NEXTSPACE development environment - one should use orignal CentOS 7 packages. I think builds to other Linux distributions should be carefuly hand-build and documented like Debian and CentOS.

Otherwise someone should test and add distribution-specific patches, packages (build toolchain, libraries) etc. It doesn't look like generic build scripts right now.

Packaging/Sources/README.md Outdated Show resolved Hide resolved
Packaging/Sources/install-dependencies-debian.sh Outdated Show resolved Hide resolved
Packaging/Sources/dependencies-debian9.txt Outdated Show resolved Hide resolved
Packaging/Sources/dependencies-debian10.txt Outdated Show resolved Hide resolved
Packaging/Sources/apply-patches.sh Show resolved Hide resolved
Packaging/Sources/9_install_scripts.sh Outdated Show resolved Hide resolved
@onflapp
Copy link
Contributor Author

onflapp commented Jul 28, 2020

@trunkmaster I moved all "debian" related stuff out of the way now.
I thought patches need to applied first, but you are right, it will build without any patching.

The idea is to have very simple build script(s).

  1. fetches sources
  2. builds the stuff
  3. make install

Building NEXTSPACE on distros other than RedHat or Debian is not that straight forward right now.
As the existing build scripts build packages and then install them, you can easily run into package versioning problems etc, etc.

This build script will build NEXTSPACE directly from source code and make install it. There is no other magic there.
Furthermore, it is not intended to replace distro specific scripts, the intention is to get you started, even if you don't have one of supported distros or you just want to "roll your own".

Copy link
Owner

@trunkmaster trunkmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not disable ICU, make small change to GNUstep Back install and this PR could be merged.

@onflapp
Copy link
Contributor Author

onflapp commented Jul 29, 2020

@trunkmaster I think I am done now.
many thanks!

Copy link
Owner

@trunkmaster trunkmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look much better, thanks.

@trunkmaster trunkmaster merged commit 9788d08 into trunkmaster:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants