Fix maximum response length check #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad I missed this in #5 |
robin-nitrokey
force-pushed
the
max-response-len
branch
from
47c65f2
to
648ec67
Compare
sosthene-nitrokey
requested changes
Feb 6, 2023
To decide whether we send out the response in whole or in chunks, we not only have to compare the length with the maximum length supported by interchange but also with the maximum response length specified in the request APDU.
robin-nitrokey
force-pushed
the
max-response-len
branch
from
648ec67
to
1e6d4cb
Compare
|
I’ve added the missing Le fields to the tests, let’s see if the CI is happy. |
sosthene-nitrokey
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decide whether we send out the response in whole or in chunks, we not only have to compare the length with the maximum length supported by interchange but also with the maximum response length specified in the request APDU.