Skip to content

Commit

Permalink
fix(a11y): move aria-label from svg icon to button (#2640)
Browse files Browse the repository at this point in the history
Co-authored-by: Chris Vincent <c.m.vincent@pm.me>
Co-authored-by: Brandon Lenz <15805554+brandonlenz@users.noreply.github.com>
  • Loading branch information
3 people committed Nov 15, 2023
1 parent 306daaa commit fa18032
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/components/header/NavCloseButton/NavCloseButton.tsx
Expand Up @@ -15,9 +15,10 @@ export const NavCloseButton = ({
className={classes}
onClick={onClick}
data-testid="navCloseButton"
aria-label="Close Navigation Menu"
{...buttonProps}
type="button">
<Icon.Close size={3} aria-label="Close" />
<Icon.Close size={3} aria-hidden="true" />
</button>
)
}

0 comments on commit fa18032

Please sign in to comment.