-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: improve DangerJS checks #2331
Conversation
042f12f
to
ad23e9a
Compare
472c975
to
e61bb5b
Compare
e61bb5b
to
3a3c8f5
Compare
@gidjin anything I can verify here? I see danger has been passing on PRs, including this one. Changes look good to me as well. |
I'm also noticing that danger currently fails on main because it's looking for things that are only defined in PR context |
@all-contributors please add @gidjin for maintenance |
I've put up a pull request to add @gidjin! 🎉 |
@gidjin what's still needed to merge this? |
I think I was trying to see how / why Danger didn't run for 3rd party PRs. Since then this isn't blocking PRs and has been running on our own PR so I'm going to close it. |
Summary
Improvements to the DangerJS checks
How To Test
Once #2330 is merged you can trigger the build checks workflow to see danger execute on this branch.