Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds in information on how to test PRs in GitHub Codespaces #2617

Merged
merged 18 commits into from
Oct 12, 2023
Merged

docs: adds in information on how to test PRs in GitHub Codespaces #2617

merged 18 commits into from
Oct 12, 2023

Commits on Oct 4, 2023

  1. creates md file and adds reference from design PR reviews doc

    @shkeating
    shkeating committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    46a9071 View commit details
    Browse the repository at this point in the history

  2. adds in md content for how to use codespaces

    @shkeating
    shkeating committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    1099945 View commit details
    Browse the repository at this point in the history

  3. updates image paths

    @shkeating
    shkeating committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ef4a135 View commit details
    Browse the repository at this point in the history

  4. Update docs/codespace_pr_reviews.md 

    Co-authored-by: Andrew Nelson <andy@andyhub.com>
    @shkeating @werdnanoslen
    shkeating and werdnanoslen committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8eaae53 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. adds more info about how to find the port address if you dont get the… 

    … message or it goes away before you click it.
    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    49ef0e7 View commit details
    Browse the repository at this point in the history

  2. adds info about what it looks like when the codespace is done configu… 

    …ring
    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2ac4616 View commit details
    Browse the repository at this point in the history

  3. resolves merge conflict

    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2f36598 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into shk-codespacesdocs-2616

    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    aad3e08 View commit details
    Browse the repository at this point in the history

  5. changes text to match what button says when creating a codespace

    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5ff2f79 View commit details
    Browse the repository at this point in the history

  6. formatting adjustments

    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e0ad426 View commit details
    Browse the repository at this point in the history

  7. adds a little more context about waiting for yarn storybook to run

    @shkeating
    shkeating committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1344026 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Update docs/codespace_pr_reviews.md 

    Co-authored-by: Kim Allen <kim@truss.works>
    @shkeating @kimallen
    shkeating and kimallen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    28f0722 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into shk-codespacesdocs-2616

    @shkeating
    shkeating committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    3a01adf View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge branch 'main' into shk-codespacesdocs-2616

    @shkeating
    shkeating committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a8dae67 View commit details
    Browse the repository at this point in the history

  2. Update docs/design-pr-reviews.md 

    Co-authored-by: Brandon Lenz <15805554+brandonlenz@users.noreply.github.com>
    @shkeating @brandonlenz
    shkeating and brandonlenz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c05ef34 View commit details
    Browse the repository at this point in the history

  3. Update docs/codespace_pr_reviews.md 

    Co-authored-by: Brandon Lenz <15805554+brandonlenz@users.noreply.github.com>
    @shkeating @brandonlenz
    shkeating and brandonlenz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    bb2cd30 View commit details
    Browse the repository at this point in the history

  4. Update docs/codespace_pr_reviews.md 

    Co-authored-by: Brandon Lenz <15805554+brandonlenz@users.noreply.github.com>
    @shkeating @brandonlenz
    shkeating and brandonlenz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    64472df View commit details
    Browse the repository at this point in the history

  5. Update docs/codespace_pr_reviews.md 

    Co-authored-by: Brandon Lenz <15805554+brandonlenz@users.noreply.github.com>
    @shkeating @brandonlenz
    shkeating and brandonlenz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e4d07e8 View commit details
    Browse the repository at this point in the history