Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace card button with link #2750

Merged
merged 15 commits into from
Mar 4, 2024
Merged

fix: replace card button with link #2750

merged 15 commits into from
Mar 4, 2024

Commits on Feb 7, 2024

  1. adds prop to Link for allowing spacebar activation, uses it to condit… 

    …ionally add a keyboard event listener to the <a> element
    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    20a0ede View commit details
    Browse the repository at this point in the history

  2. adds prop to Link for allowing spacebar activation, uses it to condit… 

    …ionally add a keyboard event listener to the <a> element
    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e2efc60 View commit details
    Browse the repository at this point in the history

  3. adds allowSpacebarActivation prop to story for StyledAsButton.

    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a1866c4 View commit details
    Browse the repository at this point in the history

  4. rewrites conditional event handler to only be applied when allowSpace… 

    …barActivation is true
    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    14e6f2f View commit details
    Browse the repository at this point in the history

  5. fixes some types on handleKeyDown

    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ebd9ff2 View commit details
    Browse the repository at this point in the history

  6. fixes typescript issues in keyboard handler

    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e846286 View commit details
    Browse the repository at this point in the history

  7. replaces all Buttons with Links in Card stories

    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e88681b View commit details
    Browse the repository at this point in the history

  8. sets all Links in Card stories to unstyled variant to allow button st… 

    …yling to override default link color
    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    62bd8b0 View commit details
    Browse the repository at this point in the history

  9. removes ={true} from allowSpacebarActivation attribute throughout upd… 

    …ated files
    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    379ec3a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into 2696-replace-card-button-with-link

    @klalicki
    klalicki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4bf907b View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Merge branch 'trussworks:main' into 2696-replace-card-button-with-link

    @klalicki
    klalicki committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c6f2722 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merge branch 'main' into 2696-replace-card-button-with-link

    @klalicki
    klalicki committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    1771b61 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Merge branch 'main' into 2696-replace-card-button-with-link

    @klalicki
    klalicki committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    49374b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. adds default value for allowSpacebarActivation prop 

    Co-authored-by: Brandon Lenz <15805554+brandonlenz@users.noreply.github.com>
    @klalicki @brandonlenz
    klalicki and brandonlenz committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    af60ffa View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge branch 'main' into 2696-replace-card-button-with-link

    @brandonlenz
    brandonlenz committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b13502c View commit details
    Browse the repository at this point in the history