fix: Duplicate classes and invalid aria props on LanguageSelector #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawyerh
commented
Apr 18, 2024
| @@ -14,6 +14,9 @@ export type LanguageSelectorProps = { | |||
| label?: string | |||
| langs: LanguageDefinition[] | |||
| small?: boolean | |||
| /** | |||
| * Custom classes for the call-to-action | |||
| */ | |||
There was a problem hiding this comment.
ℹ️ This shows in Storybook:
sawyerh
commented
Apr 18, 2024
| @@ -27,8 +25,6 @@ export const LanguageSelectorButton = ({ | |||
| <button | |||
| data-testid="languageSelectorButton" | |||
| className={classes} | |||
| aria-expanded={isOpen} | |||
| aria-controls="language-options" | |||
There was a problem hiding this comment.
ℹ️ These are now passed in as buttonProps from LanguageSelectorDropdown since that's the only context they need applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a few issues with the
LanguageSelectorimplementation:usa-language-containerclass was being applied to both the parentdivand the innerbutton, which causes layout issues due to the button receiving unexpected margins and relative positioningAn assumption I am making in this PR is that the intent of the
classNameprop is to apply custom styling to the button, which is how it's demonstrated in Storybook.How To Test
Storybook
Screenshots (optional)