Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

fix: Refactor credential manifest output descriptors #633

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

talwinder50
Copy link
Member

closes #580

Signed-off-by: talwinder50 talwinderkaur50@gmail.com

@cla-bot cla-bot bot added the cla-signed label Feb 22, 2022
@talwinder50 talwinder50 changed the title fix: Refactor credential manifest output descriptors WIP fix: Refactor credential manifest output descriptors Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #633 (4ae32a0) into main (869218a) will decrease coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   87.55%   87.55%   -0.01%     
==========================================
  Files          28       29       +1     
  Lines        4244     4258      +14     
==========================================
+ Hits         3716     3728      +12     
- Misses        308      309       +1     
- Partials      220      221       +1     
Impacted Files Coverage Δ
cmd/adapter-rest/startcmd/start.go 82.90% <77.77%> (-0.59%) ⬇️
pkg/memcmdescriptor/provider.go 100.00% <100.00%> (ø)
pkg/restapi/issuer/operation/operations.go 88.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869218a...4ae32a0. Read the comment docs.

@talwinder50 talwinder50 force-pushed the issue-595 branch 4 times, most recently from a0d1582 to 486f2c6 Compare February 22, 2022 16:59
@talwinder50 talwinder50 changed the title WIP fix: Refactor credential manifest output descriptors fix: Refactor credential manifest output descriptors Feb 22, 2022
cmd/adapter-rest/startcmd/start.go Outdated Show resolved Hide resolved
pkg/cmdescriptor/provider.go Outdated Show resolved Hide resolved
pkg/cmdescriptor/provider.go Outdated Show resolved Hide resolved
pkg/cmdescriptor/provider.go Outdated Show resolved Hide resolved
@talwinder50 talwinder50 force-pushed the issue-595 branch 3 times, most recently from 40b5615 to 47f4515 Compare February 23, 2022 17:54
closes trustbloc#580

Signed-off-by: talwinder50 <talwinderkaur50@gmail.com>
@talwinder50 talwinder50 merged commit f4a3138 into trustbloc:main Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create helper function for credential manifest output descriptors
3 participants