This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
feat: Update to latest aries and support for submission requirement #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talwinder50
force-pushed
the
issue-545
branch
2 times, most recently
from
5db49f5
to
fa0b568
Compare
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 87.55% 87.74% +0.19%
==========================================
Files 29 29
Lines 4258 4309 +51
==========================================
+ Hits 3728 3781 +53
+ Misses 309 308 -1
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
talwinder50
force-pushed
the
issue-545
branch
7 times, most recently
from
c1adfcc
to
e77e19a
Compare
pkg/memcmdescriptor/provider.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("failed to unmarshal presentation"+ | ||
| "definition: %w", err) | ||
| } |
There was a problem hiding this comment.
Why do we need to marshal first and then unmarshal the same thing ?
There was a problem hiding this comment.
i have updated the logic to much simpler version , no longer require this
| if credManifest.PresentationDefinition != nil { | ||
| applicationAttachments, err := getAttachments(msg) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get request credential attachments: %w", err) | ||
| } | ||
|
|
||
| if len(applicationAttachments) != 1 { | ||
| return errors.New("invalid request credential message, expected valid credential application") | ||
| attachmentAsMap, ok := applicationAttachments[0].Data.JSON.(map[string]interface{}) |
There was a problem hiding this comment.
Can't we use applicationAttachments[0].Data.JSON and unmarshaling than type casting to map ?
talwinder50
force-pushed
the
issue-545
branch
from
e77e19a
to
48834ca
Compare
closes trustbloc#612 Signed-off-by: talwinder50 <talwinderkaur50@gmail.com>
talwinder50
force-pushed
the
issue-545
branch
from
48834ca
to
c8b721e
Compare
rolsonquadras
approved these changes
Feb 28, 2022
fqutishat
approved these changes
Mar 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #612
Signed-off-by: talwinder50 talwinderkaur50@gmail.com