feat: Auth vue setup and configure tailwind #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 85.80% 85.80%
=======================================
Files 5 5
Lines 310 310
=======================================
Hits 266 266
Misses 29 29
Partials 15 15 Continue to review full report at Codecov.
|
cmd/auth-vue/src/assets/.gitkeep
Outdated
| # Copyright SecureKey Technologies Inc. All Rights Reserved. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # |
There was a problem hiding this comment.
Not sure if it's really important, but there's a "no newline" warning here showing up in the GitHub diff UI
There was a problem hiding this comment.
it shows up at the end of files.
It's actually good practice to always leave an empty line at the end of files. This way the diff is a bit less confusing if you happen to change the last line with contents
| src="https://upload.wikimedia.org/wikipedia/commons/thumb/5/53/Google_%22G%22_Logo.svg/512px-Google_%22G%22_Logo.svg.png"/> | ||
| </a> | ||
| <a href="" class="mx-auto bg-gray-100 lg:mx-0 border hover:underline my-4 py-2 px-8 shadow-lg"> | ||
| <img class="object-scale-down h-8 w-32" alt="Google "G" Logo" | ||
| src="https://upload.wikimedia.org/wikipedia/commons/9/91/Octicons-mark-github.svg"/> |
There was a problem hiding this comment.
Just a thought... Would it be a good idea if these resources are hosted internally? Just in case the external sitre goes down?
There was a problem hiding this comment.
I dont have very strong preference , Linking and embedding both have their pros and cons. Embedded images on git has to be stored on git lfs for the efficient storage purpose. If its not bothersome, i will set up git-lfs and add these images to the that in the following pr.
There was a problem hiding this comment.
I would probably vote for hosting it internally - I'm not sure if wikimedia ever moves their stuff around... but I think it would be fair to do it in a separate PR
|
|
||
| module.exports = { | ||
| publicPath: "/ui" | ||
| } |
Agreed - thanks @talwinder50 ! |
@talwinder50 has agreed to do this in a followup PR |
talwinder50
force-pushed
the
issue-8
branch
2 times, most recently
from
d5b59a6
to
fe7c6b3
Compare
closes trustbloc#8 Signed-off-by: talwinder.kaur <talwinder.kaur@securekey.com>
closes #8
Signed-off-by: talwinder.kaur talwinder.kaur@securekey.com
