This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: device cert validation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs unit tests and some work on defining the rest api |
llorllale
reviewed
Oct 27, 2020
llorllale
reviewed
Oct 27, 2020
|
@Moopli this endpoint must also register and associate the device to the user's profile, therefore needs as input the user's |
|
Also, endpoint path should be renamed to just |
Moopli
force-pushed
the
verify-device-cert
branch
2 times, most recently
from
a51c561
to
b9d1230
Compare
llorllale
reviewed
Oct 29, 2020
pkg/bootstrap/user/userprofile.go
Outdated
| @@ -16,6 +16,7 @@ import ( | |||
| // Profile is the user's bootstrap profile. | |||
| type Profile struct { | |||
| ID string | |||
| AAGUID string | |||
llorllale
approved these changes
Oct 29, 2020
Moopli
force-pushed
the
verify-device-cert
branch
from
b9d1230
to
315e74e
Compare
talwinder50
approved these changes
Oct 29, 2020
|
Codecov should be fixed. |
Moopli
force-pushed
the
verify-device-cert
branch
from
315e74e
to
2dd63ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 8 8
Lines 455 520 +65
=======================================
+ Hits 399 456 +57
- Misses 34 39 +5
- Partials 22 25 +3
Continue to review full report at Codecov.
|
Merged
Moopli
force-pushed
the
verify-device-cert
branch
from
2dd63ab
to
ffb5307
Compare
Registers a user device AAGUID to the user's profile,
after validating that the device's certificate is valid
according to the given intermediate certificates and
the server's trusted set of device root CAs.
POST to /device with a JSON body:
{
"x5c": [
"---USER DEVICE CERT, PEM ENCODED---",
"---INTERMEDIATE CERT 1, PEM ENCODED---",
"---INTERMEDIATE CERT 2, PEM ENCODED---",
...
],
"sub": "user sub",
"aaguid": "user device AAGUID" [optional]
}
Closes trustbloc#56
Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
Moopli
force-pushed
the
verify-device-cert
branch
from
ffb5307
to
9f8daf4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filip Burlacu filip.burlacu@securekey.com