This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
[ON-HOLD] feat: State DB Cache #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolsonquadras
force-pushed
the
issue-87-statedb
branch
from
e6a2ec0
to
4563de6
Compare
rolsonquadras
force-pushed
the
issue-87-statedb
branch
from
4563de6
to
26bd379
Compare
golangcibot
reviewed
May 21, 2019
| @@ -9,3 +13,7 @@ import ( | |||
| func SetupExtTestEnv() (addr string, cleanup func(string), stop func()) { | |||
| return testutil.SetupExtTestEnv() | |||
| } | |||
|
|
|||
| func GetExtStateDBProvider(t testing.TB, dbProvider statedb.VersionedDBProvider) statedb.VersionedDBProvider { | |||
There was a problem hiding this comment.
exported function GetExtStateDBProvider should have comment or be unexported (from golint)
| logger.Debugf("Removed folder [%s] for test environment for %s", dbPath, caller) | ||
| } | ||
|
|
||
| func GetExtStateDBProvider(t testing.TB, dbProvider statedb.VersionedDBProvider) statedb.VersionedDBProvider { |
There was a problem hiding this comment.
exported function GetExtStateDBProvider should have comment or be unexported (from golint)
rolsonquadras
force-pushed
the
issue-87-statedb
branch
from
26bd379
to
08c5659
Compare
rolsonquadras
force-pushed
the
issue-87-statedb
branch
from
08c5659
to
12388d0
Compare
- Add a new implementation of VersionedDBProvider and VersionedDB to wrap existing db implementations(leveldb/couchdb) and to support caching of the data. - Add state db cache store using gCache library. Closes trustbloc#87 Signed-off-by: Rolson Quadras <rolson.quadras@securekey.com>
rolsonquadras
force-pushed
the
issue-87-statedb
branch
from
12388d0
to
bff5700
Compare
|
This will not be implemented as HL Fabric is adding part of fabric core. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Signed-off-by: Rolson Quadras rolson.quadras@securekey.com