chore: Add 0 or positive check for minimum number of witnesses required. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for minimum number of witnesses in witness policy rule OutOf() we only check for integer for first parameter. It should be 0 or positive integer since it denotes minimum number of witnesses required to satisfy policy. Percent rule MinPercent() is already enforcing integer that is between 0 and 100 which is correct for percent. Closes trustbloc#1025 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 89.31% 89.35% +0.03%
==========================================
Files 160 160
Lines 15530 15596 +66
==========================================
+ Hits 13871 13936 +65
+ Misses 1014 1013 -1
- Partials 645 647 +2
Continue to review full report at Codecov.
|
bstasyszyn
approved these changes
Jan 15, 2022
fqutishat
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for minimum number of witnesses in witness policy rule OutOf() we only check for integer for first parameter. It should be 0 or positive integer since it denotes minimum number of witnesses required to satisfy policy.
Percent rule MinPercent() is already enforcing integer that is between 0 and 100 which is correct for percent.
Closes #1025
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com