Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: http client in cli #1071

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix: http client in cli #1071

merged 1 commit into from
Jan 31, 2022

Conversation

fqutishat
Copy link
Contributor

Signed-off-by: Firas Qutishat firas.qutishat@securekey.com

Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1071 (a36c5b9) into main (f75258f) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
+ Coverage   89.24%   89.27%   +0.03%     
==========================================
  Files         161      161              
  Lines       15654    15674      +20     
==========================================
+ Hits        13970    13993      +23     
+ Misses       1033     1029       -4     
- Partials      651      652       +1     
Impacted Files Coverage Δ
cmd/orb-cli/createdidcmd/createdid.go 92.79% <100.00%> (+3.07%) ⬆️
cmd/orb-cli/deactivatedidcmd/deactivatedid.go 92.77% <100.00%> (+0.36%) ⬆️
cmd/orb-cli/recoverdidcmd/recoverdid.go 94.07% <100.00%> (+0.18%) ⬆️
cmd/orb-cli/resolvedidcmd/resolvedid.go 84.70% <100.00%> (+0.75%) ⬆️
cmd/orb-cli/updatedidcmd/updatedid.go 95.00% <100.00%> (+0.17%) ⬆️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75258f...a36c5b9. Read the comment docs.

@fqutishat fqutishat merged commit d1c889c into trustbloc:main Jan 31, 2022
@fqutishat fqutishat deleted the update branch January 31, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants