Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Processes inboxes before outboxes in activity sync #1090

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

bstasyszyn
Copy link
Contributor

First process the anchor activities from the inboxes of its followers before the outboxes of those following it. This ensures that any potential loss of data is recovered first.

Also, rename the startup env variable ANCHOR_EVENT_MIN_ACTIVITY_AGE to ANCHOR_EVENT_SYNC_MIN_ACTIVITY_AGE.

closes #1089

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

First process the anchor activities from the inboxes of its followers before the outboxes of those following it. This ensures that any potential loss of data is recovered first.

Also, rename the startup env variable ANCHOR_EVENT_MIN_ACTIVITY_AGE to ANCHOR_EVENT_SYNC_MIN_ACTIVITY_AGE.

closes trustbloc#1089

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1090 (75fdd09) into main (b8c97f4) will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   89.20%   89.22%   +0.01%     
==========================================
  Files         161      161              
  Lines       15722    15722              
==========================================
+ Hits        14025    14028       +3     
+ Misses       1042     1040       -2     
+ Partials      655      654       -1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/params.go 80.88% <ø> (ø)
...vitypub/service/anchorsynctask/activitysynctask.go 87.57% <93.75%> (ø)
pkg/activitypub/service/monitoring/monitoring.go 80.18% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c97f4...75fdd09. Read the comment docs.

@bstasyszyn bstasyszyn merged commit a6d8316 into trustbloc:main Feb 2, 2022
@bstasyszyn bstasyszyn deleted the 1089 branch February 2, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity sync should process inbox before outbox
2 participants