Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add startup parameters for AMQP redelivery #1111

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

bstasyszyn
Copy link
Contributor

closes #1110

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Feb 8, 2022
@bstasyszyn bstasyszyn marked this pull request as draft February 8, 2022 14:57
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1111 (be2200f) into main (803977a) will decrease coverage by 0.03%.
The diff coverage is 67.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   89.28%   89.24%   -0.04%     
==========================================
  Files         161      161              
  Lines       15832    15867      +35     
==========================================
+ Hits        14136    14161      +25     
- Misses       1040     1047       +7     
- Partials      656      659       +3     
Impacted Files Coverage Δ
pkg/context/opqueue/opqueue.go 82.60% <ø> (ø)
pkg/observer/observer.go 83.26% <0.00%> (ø)
pkg/pubsub/amqp/amqppubsub.go 89.37% <ø> (ø)
cmd/orb-server/startcmd/start.go 73.54% <25.00%> (-0.45%) ⬇️
cmd/orb-server/startcmd/params.go 80.66% <75.00%> (-0.35%) ⬇️
pkg/observer/pubsub.go 97.24% <100.00%> (+2.75%) ⬆️
pkg/pubsub/amqp/pooledsubscriber.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803977a...be2200f. Read the comment docs.

@bstasyszyn bstasyszyn marked this pull request as ready for review February 8, 2022 15:00
closes trustbloc#1110

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit 4e4c324 into trustbloc:main Feb 8, 2022
@bstasyszyn bstasyszyn deleted the 1110 branch February 8, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMQP redelivery parameters should be configurable
3 participants