Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add BDD test for Sidetree protocol version #1121

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

sandrask
Copy link
Contributor

Add BDD test for Sidetree protocol version.

Closes #994

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1121 (3566833) into main (a9e84b3) will increase coverage by 0.07%.
The diff coverage is 98.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   88.83%   88.91%   +0.07%     
==========================================
  Files         161      167       +6     
  Lines       16030    16195     +165     
==========================================
+ Hits        14240    14399     +159     
- Misses       1106     1109       +3     
- Partials      684      687       +3     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 73.47% <ø> (-0.11%) ⬇️
...tocolversion/versions/test/v_test/client/client.go 93.33% <93.33%> (ø)
cmd/orb-server/startcmd/params.go 80.89% <100.00%> (+0.31%) ⬆️
...nerator/didorbtestgenerator/didorbtestgenerator.go 100.00% <100.00%> (ø)
.../anchor/anchorevent/generator/generatorregistry.go 100.00% <100.00%> (ø)
pkg/context/protocol/client/client.go 100.00% <100.00%> (ø)
...g/protocolversion/clientregistry/clientregistry.go 100.00% <100.00%> (ø)
pkg/protocolversion/clientregistry/versions.go 100.00% <100.00%> (ø)
...protocolversion/factoryregistry/factoryregistry.go 100.00% <100.00%> (ø)
pkg/protocolversion/factoryregistry/versions.go 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e84b3...3566833. Read the comment docs.

@sandrask sandrask changed the title chore: Add BDD test for Sidetree protocol version wip: Add BDD test for Sidetree protocol version Feb 14, 2022
@sandrask sandrask changed the title wip: Add BDD test for Sidetree protocol version test: Add BDD test for Sidetree protocol version Feb 15, 2022
//go:build !testver
// +build !testver

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this file to versions.go.

//go:build testver
// +build testver

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And rename this file to testversions.go

Add BDD test for Sidetree protocol version.

Closes trustbloc#994

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@bstasyszyn bstasyszyn merged commit 12f36c2 into trustbloc:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BDD test for upgrading DID version
3 participants