Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Modify create-dids-to-file BDD test #1124

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

bstasyszyn
Copy link
Contributor

  • Modify the step, create_dids_to_file, so that the DIDs are not verified. This allows other steps to immediatley run withouthout waiting for the DIDs to be anchored.
  • Modify step, verify_created_dids_from_file, to add the env parameter ORB_BACKUP_VERIFY_ATTEMPTS to specifiy the maximum number of attempts to verify that a DID has been anchored.

closes #1122

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

- Modify the step, create_dids_to_file, so that the DIDs are not verified. This allows other steps to immediatley run withouthout waiting for the DIDs to be anchored.
- Modify step, verify_created_dids_from_file, to add the env parameter ORB_BACKUP_VERIFY_ATTEMPTS to specifiy the maximum number of attempts to verify that a DID has been anchored.

closes trustbloc#1122

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1124 (5eaf8d2) into main (286df1f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
+ Coverage   88.84%   88.91%   +0.06%     
==========================================
  Files         161      161              
  Lines       16060    16060              
==========================================
+ Hits        14268    14279      +11     
+ Misses       1107     1098       -9     
+ Partials      685      683       -2     
Impacted Files Coverage Δ
pkg/observer/pubsub.go 94.49% <0.00%> (ø)
pkg/activitypub/service/monitoring/monitoring.go 80.18% <0.00%> (+2.83%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 100.00% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286df1f...5eaf8d2. Read the comment docs.

@bstasyszyn bstasyszyn merged commit 8ee61bc into trustbloc:main Feb 14, 2022
@bstasyszyn bstasyszyn deleted the 1122 branch February 14, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orb backup/recovery bdd test
3 participants