chore: Add BDD test for retrieving documents by versionID #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 88.92% 88.99% +0.06%
==========================================
Files 168 168
Lines 16260 16261 +1
==========================================
+ Hits 14460 14472 +12
+ Misses 1112 1103 -9
+ Partials 688 686 -2
Continue to review full report at Codecov.
|
bstasyszyn
reviewed
Feb 25, 2022
| Then check success response contains "thirdKey" | ||
|
|
||
| # start version queries | ||
| When client sends request to "https://orb.domain1.com/sidetree/v1/identifiers" to resolve DID document with canonical did and version index 0 |
There was a problem hiding this comment.
What does version index mean?
There was a problem hiding this comment.
just a way of collecting version ids in BDD test - I will change it as per our conversation
bstasyszyn
reviewed
Feb 25, 2022
| @@ -807,6 +821,22 @@ func (d *DIDOrbSteps) resolveDIDDocumentWithCanonicalDID(url string) error { | |||
| return d.resolveDIDDocumentWithID(url, d.canonicalDID) | |||
| } | |||
|
|
|||
| func (d *DIDOrbSteps) resolveDIDDocumentWithCanonicalDIDAndVersion(url, version string) error { | |||
| logger.Infof("resolving did document with canonical did %s and version %s", d.canonicalDID, version) | |||
There was a problem hiding this comment.
You can do this:
if err := d.state.resolveVarsInExpression(&version); err != nil {
return err
}
didWithParam := d.canonicalDID + "?versionId=" + version
| Then check success response contains "canonicalId" | ||
| Then the JSON path 'didDocumentMetadata.versionId' of the response is saved to variable "v0" | ||
|
|
||
| When client sends request to "https://orb.domain1.com/sidetree/v1/identifiers" to resolve DID document with canonical did and version "v0" |
There was a problem hiding this comment.
Do this instead:
. . . canonical did and version "${v0}"
Update sidetree-core, add BDD test for retrieving documents by versionId. Closes trustbloc#1148 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
bstasyszyn
approved these changes
Feb 25, 2022
fqutishat
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sidetree-core, add BDD test for retrieving documents by versionId.
Closes #1148
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com