chore: BDD test for resolve DID with versionId #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrask
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 88.99% 88.94% -0.05%
==========================================
Files 168 168
Lines 16261 16270 +9
==========================================
Hits 14472 14472
- Misses 1103 1110 +7
- Partials 686 688 +2
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Mar 1, 2022
bstasyszyn
reviewed
Mar 1, 2022
test/bdd/common_steps.go
Outdated
| func (d *CommonSteps) setVariableToCurrentTime(varName string) error { | ||
| value := time.Now().UTC().Format(time.RFC3339) | ||
|
|
||
| if err := d.state.resolveVarsInExpression(&value); err != nil { |
There was a problem hiding this comment.
You don't need this code.
There was a problem hiding this comment.
You don't need this code.
value will never have variables so calling resolveVarsInExpression is not necessary
Update sidetree-core and add BDD test for resolver DID with versionTime parameter Closes trustbloc#1151 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
bstasyszyn
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sidetree-core and add BDD test for resolve DID with versionTime parameter
Closes #1151
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com