Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Linkset for anchor #1180

Merged
merged 1 commit into from
Mar 17, 2022
Merged

feat: Use Linkset for anchor #1180

merged 1 commit into from
Mar 17, 2022

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Mar 16, 2022

Change the anchor model to remove AnchorEvent from anchor data that is persisted and instead use Linksets. The AnchorEvent is only used for wrapping the Linkset in Create and Announce activities.

closes #1145

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Mar 16, 2022
@bstasyszyn bstasyszyn marked this pull request as draft March 16, 2022 22:13
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1180 (c1dabb0) into main (bbae2bf) will decrease coverage by 0.32%.
The diff coverage is 81.32%.

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   88.63%   88.30%   -0.33%     
==========================================
  Files         171      171              
  Lines       16883    16831      -52     
==========================================
- Hits        14964    14863     -101     
- Misses       1204     1239      +35     
- Partials      715      729      +14     
Impacted Files Coverage Δ
pkg/activitypub/store/spi/spi.go 25.00% <ø> (ø)
pkg/activitypub/vocab/util.go 83.33% <ø> (+7.26%) ⬆️
pkg/activitypub/vocab/vocab.go 100.00% <ø> (ø)
.../anchor/anchorlinkset/vcresthandler/resthandler.go 89.65% <ø> (ø)
pkg/store/anchorstatus/store.go 96.51% <ø> (ø)
...tivitypub/service/activityhandler/outboxhandler.go 76.38% <50.00%> (-2.98%) ⬇️
pkg/hashlink/hashlink.go 90.90% <50.00%> (-2.89%) ⬇️
pkg/anchor/anchorlinkset/anchorlinkset.go 62.63% <62.63%> (ø)
...ctivitypub/service/activityhandler/inboxhandler.go 83.16% <66.23%> (-1.20%) ⬇️
cmd/orb-server/startcmd/start.go 71.20% <66.66%> (-0.46%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbae2bf...c1dabb0. Read the comment docs.

@bstasyszyn bstasyszyn force-pushed the 1145-5 branch 3 times, most recently from 93fa76a to 7e45e7b Compare March 17, 2022 19:03
Change the anchor model to remove AnchorEvent from anchor data that is persisted and instead use Linksets. The ANchorEvent is only used for wrapping the Linkset in Create and Announce activities.

closes trustbloc#1145

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn marked this pull request as ready for review March 17, 2022 19:25
@fqutishat fqutishat merged commit dd66f1b into trustbloc:main Mar 17, 2022
@bstasyszyn bstasyszyn deleted the 1145-5 branch March 17, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace AnchorEvent with Linkset
3 participants