Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry on failures while DIDs are created #1206

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

bstasyszyn
Copy link
Contributor

Also fixes a potential race condition in witness store.

closes #1203

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Mar 28, 2022
@bstasyszyn bstasyszyn force-pushed the 1203-2 branch 2 times, most recently from a71fc01 to 073ce8d Compare March 28, 2022 21:05
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1206 (7d43559) into main (5f66bd8) will decrease coverage by 0.33%.
The diff coverage is 74.46%.

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
- Coverage   88.09%   87.75%   -0.34%     
==========================================
  Files         172      172              
  Lines       17110    17214     +104     
==========================================
+ Hits        15073    15107      +34     
- Misses       1296     1339      +43     
- Partials      741      768      +27     
Impacted Files Coverage Δ
...pub/service/inbox/httpsubscriber/httpsubscriber.go 88.88% <0.00%> (-2.03%) ⬇️
pkg/anchor/witness/proof/proof.go 100.00% <ø> (ø)
pkg/activitypub/client/client.go 86.34% <50.00%> (-0.19%) ⬇️
pkg/cas/resolver/resolver.go 88.88% <62.50%> (-0.89%) ⬇️
pkg/store/witness/witness.go 80.07% <71.32%> (-11.55%) ⬇️
pkg/webfinger/client/client.go 87.50% <77.77%> (-0.62%) ⬇️
pkg/activitypub/service/outbox/outbox.go 86.31% <78.31%> (-3.12%) ⬇️
pkg/anchor/writer/writer.go 88.23% <94.73%> (-0.09%) ⬇️
...ypub/service/outbox/httppublisher/httppublisher.go 83.33% <100.00%> (ø)
pkg/activitypub/service/vct/vct.go 83.33% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f66bd8...7d43559. Read the comment docs.

@bstasyszyn bstasyszyn force-pushed the 1203-2 branch 3 times, most recently from c31c0c7 to f0d7e88 Compare March 31, 2022 13:49
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
14.5% 14.5% Duplication

@bstasyszyn bstasyszyn marked this pull request as ready for review March 31, 2022 18:07
@bstasyszyn bstasyszyn force-pushed the 1203-2 branch 2 times, most recently from accf6a2 to 9d281bd Compare March 31, 2022 18:33
Also fixes a potential race condition in witness store.

closes trustbloc#1203

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
22.6% 22.6% Duplication

@bstasyszyn bstasyszyn merged commit a6c658e into trustbloc:main Mar 31, 2022
@bstasyszyn bstasyszyn deleted the 1203-2 branch March 31, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIDs are lost when domain instance goes down
3 participants