Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Updated onboarding and recover BDD test to handle instance failure #1230

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Apr 7, 2022

Modified the existing onboarding-and-recovery BDD test to take down an Orb instance while DIDs are being created, in order to prove that no DIDs are lost in a busy system when a domain instance goes down.

Also added a fix to the HTTP signature verifier to propagate a transient HTTP error to the caller so that a transient error may be retried.

closes #1225

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1230 (e0cbb6d) into main (acbb3fa) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   87.87%   87.83%   -0.05%     
==========================================
  Files         171      171              
  Lines       17273    17289      +16     
==========================================
+ Hits        15179    15186       +7     
- Misses       1333     1341       +8     
- Partials      761      762       +1     
Impacted Files Coverage Δ
pkg/anchor/util/util.go 86.66% <50.00%> (+0.95%) ⬆️
pkg/activitypub/client/client.go 86.11% <57.14%> (-0.23%) ⬇️
pkg/activitypub/httpsig/verifier.go 95.65% <100.00%> (+1.00%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 88.88% <0.00%> (-8.89%) ⬇️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acbb3fa...e0cbb6d. Read the comment docs.

Modified the existing onboarding-and-recovery BDD test to take down an Orb instance while DIDs were being created in order to prove that no messages are lost in a busy system when a domain instance goes down.

Also added a fix to the HTTP signature verifier to propagate a transient HTTP error to the caller so that a transient error may be retried.

closes trustbloc#1225

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit e76de46 into trustbloc:main Apr 8, 2022
@bstasyszyn bstasyszyn deleted the 1225 branch April 8, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BDD test for Orb instance failure
3 participants