feat: Store log entries #1245
Merged
feat: Store log entries #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1245 +/- ##
==========================================
- Coverage 87.92% 87.92% -0.01%
==========================================
Files 171 173 +2
Lines 17290 17364 +74
==========================================
+ Hits 15203 15267 +64
- Misses 1329 1337 +8
- Partials 758 760 +2
Continue to review full report at Codecov.
|
sandrask
force-pushed
the
issue-1240
branch
2 times, most recently
from
2528c78
to
58308ae
Compare
fqutishat
approved these changes
Apr 20, 2022
sandrask
force-pushed
the
issue-1240
branch
2 times, most recently
from
b6d4576
to
1b5263b
Compare
bstasyszyn
approved these changes
Apr 20, 2022
| return nil, fmt.Errorf("failed to open log entry store: %w", err) | ||
| } | ||
|
|
||
| return &Store{ |
There was a problem hiding this comment.
Do you need to configure the index tags?
There was a problem hiding this comment.
I do if I need to retrieve specific entry later (e.g. log 'A' + entry '1'). I am not 100% sure that I need this use case later on but it seems reasonable to be able to retrieve it. I can remove it later on if I don't need. I have to think about all the queries that we may need from log entries later on.
Store log entries. Closes trustbloc#1240 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store log entries.
Closes #1240
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com