Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused vct discovery domains parameter #1266

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Apr 27, 2022

Remove unused VCT discovery domains parameter

Closes #1265

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

Remove VCT discovery domains parameter

Closes trustbloc#1265

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1266 (b00b4f1) into main (412eb48) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   87.92%   87.82%   -0.10%     
==========================================
  Files         173      174       +1     
  Lines       17397    17510     +113     
==========================================
+ Hits        15296    15379      +83     
- Misses       1338     1363      +25     
- Partials      763      768       +5     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/params.go 81.72% <ø> (-0.07%) ⬇️
cmd/orb-server/startcmd/start.go 68.07% <ø> (-0.17%) ⬇️
pkg/discovery/endpoint/restapi/operations.go 89.29% <ø> (-0.04%) ⬇️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 88.88% <0.00%> (-8.89%) ⬇️
pkg/pubsub/mempubsub/mempubsub.go 95.00% <0.00%> (-1.94%) ⬇️
pkg/pubsub/amqp/amqppubsub.go 87.70% <0.00%> (-1.68%) ⬇️
cmd/orb-driver/startcmd/start.go 50.00% <0.00%> (-1.41%) ⬇️
pkg/store/publickey/publickeystore.go 90.62% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412eb48...b00b4f1. Read the comment docs.

@sandrask sandrask changed the title chore: Remove vct discovery domains parameter chore: Remove unused vct discovery domains parameter Apr 27, 2022
@fqutishat fqutishat merged commit 671045e into trustbloc:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove VCT discovery domains
4 participants