Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add environment variable for no VCT version #1294

Merged
merged 1 commit into from
May 11, 2022

Conversation

sandrask
Copy link
Contributor

We should be able to spin orb without any configuration so add VCT enabled/disabled flag.

Closes #1287

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1294 (baa3fe6) into main (70d59f2) will decrease coverage by 0.01%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   87.94%   87.93%   -0.02%     
==========================================
  Files         179      179              
  Lines       17835    17851      +16     
==========================================
+ Hits        15685    15697      +12     
- Misses       1372     1375       +3     
- Partials      778      779       +1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 68.01% <50.00%> (-0.20%) ⬇️
cmd/orb-server/startcmd/params.go 81.95% <100.00%> (+0.18%) ⬆️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d59f2...baa3fe6. Read the comment docs.

We should be able to spin orb without any configuration so add VCT enabled/disabled flag.

Closes trustbloc#1287

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@fqutishat fqutishat merged commit 38929cb into trustbloc:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add environment variable for no VCT version
3 participants