Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to latest version of watermill-amqp #1298

Merged
merged 1 commit into from
May 11, 2022

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented May 11, 2022

The latest watermill-amqp library fixes a deadlock that occurs in the subscriber after a RabbitMQ restart and adds a publisher delivery confirmation option. This PR replaces the forked version of the watermill-amqp library.

closes #1270

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

The latest watermill-amqp library fixes a deadlock that occurs in the subscriber after a RabbitMQ restart and adds a publisher delivery confirmation option.

closes trustbloc#1270

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1298 (556fb30) into main (38929cb) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
+ Coverage   87.93%   87.96%   +0.02%     
==========================================
  Files         179      182       +3     
  Lines       17851    17925      +74     
==========================================
+ Hits        15697    15767      +70     
- Misses       1375     1377       +2     
- Partials      779      781       +2     
Impacted Files Coverage Δ
pkg/observer/pubsub.go 94.49% <0.00%> (ø)
cmd/orb-cli/policycmd/getcmd.go 91.66% <0.00%> (ø)
cmd/orb-cli/policycmd/policy.go 100.00% <0.00%> (ø)
cmd/orb-cli/policycmd/updatecmd.go 94.44% <0.00%> (ø)
cmd/orb-cli/main.go 75.00% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38929cb...556fb30. Read the comment docs.

@sandrask sandrask merged commit 7c8c638 into trustbloc:main May 11, 2022
@bstasyszyn bstasyszyn deleted the 1270 branch May 11, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest watermill-amqp library
4 participants