Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add log monitor get, activate, deactivate cmd to CLI #1300

Merged
merged 1 commit into from
May 12, 2022

Conversation

sandrask
Copy link
Contributor

Add log monitor get, activate, deactivate cmd to CLI

Closes #1299

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

Add log monitor get, activate, deactivate cmd to CLI

Closes trustbloc#1299

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1300 (ae78801) into main (7c8c638) will increase coverage by 0.03%.
The diff coverage is 92.23%.

@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
+ Coverage   87.91%   87.94%   +0.03%     
==========================================
  Files         182      185       +3     
  Lines       17925    18038     +113     
==========================================
+ Hits        15759    15864     +105     
- Misses       1384     1388       +4     
- Partials      782      786       +4     
Impacted Files Coverage Δ
cmd/orb-cli/logmonitorcmd/getcmd.go 86.66% <86.66%> (ø)
cmd/orb-cli/logmonitorcmd/updatecmd.go 92.98% <92.98%> (ø)
cmd/orb-cli/logmonitorcmd/logmonitor.go 100.00% <100.00%> (ø)
cmd/orb-cli/main.go 75.75% <100.00%> (+0.75%) ⬆️
pkg/context/context.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8c638...ae78801. Read the comment docs.

@@ -86,3 +86,22 @@ Feature: Using Orb CLI
When orb-cli is executed with args 'policy update --url https://localhost:48326/policy --policy "MinPercent(100,batch) AND OutOf(1,system)" --tls-cacerts fixtures/keys/tls/ec-cacert.pem --auth-token ADMIN_TOKEN'
And orb-cli is executed with args 'policy get --url https://localhost:48326/policy --tls-cacerts fixtures/keys/tls/ec-cacert.pem --auth-token READ_TOKEN'
Then the response equals "MinPercent(100,batch) AND OutOf(1,system)"

@orb_cli_logmonitor
Scenario: test accept list management using cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a copy/paste mistake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I will fix it in my next PR

@bstasyszyn bstasyszyn merged commit 5c5e8db into trustbloc:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add log monitor get, activate, deactivate cmd to CLI
3 participants