Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify a subnet for workplace VPN compatibility #1313

Merged
merged 1 commit into from
May 27, 2022

Conversation

christopherwood
Copy link
Contributor

Depending on the routes given out by workplace VPNs somebody may have
trouble running the tutorial when on a workplace VPN.

$ docker-compose -f docker-compose-cli.yml -f ../docker/docker-compose-dev.yml up
Creating network "tutorial_default" with the default driver
ERROR: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network

By specifying the network used for all containers we can run all the
"up" parts of the docker-compose step without encountering this error.

@cla-bot
Copy link

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@christopherwood christopherwood marked this pull request as draft May 27, 2022 14:24
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1313 (edad12d) into main (0f698e3) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   87.88%   87.91%   +0.02%     
==========================================
  Files         190      190              
  Lines       18299    18299              
==========================================
+ Hits        16082    16087       +5     
+ Misses       1412     1407       -5     
  Partials      805      805              
Impacted Files Coverage Δ
pkg/vct/proofmonitoring/monitoring.go 83.63% <0.00%> (-2.73%) ⬇️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 97.77% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f698e3...edad12d. Read the comment docs.

@fqutishat fqutishat marked this pull request as ready for review May 27, 2022 14:27
@cla-bot
Copy link

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@cla-bot
Copy link

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

Depending on the routes given out by workplace VPNs somebody may have trouble running the tutorial when on a workplace VPN.

$ docker-compose -f docker-compose-cli.yml -f ../docker/docker-compose-dev.yml up
Creating network "tutorial_default" with the default driver
ERROR: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network

By specifying the network used for all containers we can run all the "up" parts of the docker-compose step without encountering this error.

Signed-off-by: Christopher Wood <christopher_wood@pobox.com>
@cla-bot
Copy link

cla-bot bot commented May 27, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@bstasyszyn bstasyszyn merged commit f4945a7 into trustbloc:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants