Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimized orb-config store #1339

Merged
merged 1 commit into from
Jun 10, 2022
Merged

feat: Optimized orb-config store #1339

merged 1 commit into from
Jun 10, 2022

Conversation

bstasyszyn
Copy link
Contributor

Changes the way various subsystems store configuration data, including:

  • KMS key IDs
  • accept-list
  • log-entry config
  • witness policy

closes #1329

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Changes the way various subsystems store configuration data, including:

- KMS key IDs
- accept-list
- log-entry config
- witness policy

closes trustbloc#1329

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1339 (22f6e4f) into main (dc076da) will increase coverage by 0.01%.
The diff coverage is 92.39%.

@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
+ Coverage   88.02%   88.04%   +0.01%     
==========================================
  Files         191      192       +1     
  Lines       18493    18507      +14     
==========================================
+ Hits        16278    16294      +16     
+ Misses       1412     1411       -1     
+ Partials      803      802       -1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 67.92% <80.95%> (-0.28%) ⬇️
pkg/activitypub/service/acceptlist/acceptlist.go 88.59% <85.00%> (+1.30%) ⬆️
pkg/anchor/witness/policy/config/policystore.go 100.00% <100.00%> (ø)
pkg/anchor/witness/policy/policy.go 98.74% <100.00%> (-0.04%) ⬇️
.../anchor/witness/policy/resthandler/configurator.go 92.10% <100.00%> (-1.08%) ⬇️
pkg/anchor/witness/policy/resthandler/retriever.go 100.00% <100.00%> (ø)
pkg/config/client/client.go 95.45% <100.00%> (ø)
pkg/vct/resthandler/configurator.go 94.44% <100.00%> (+0.21%) ⬆️
pkg/vct/resthandler/retriever.go 100.00% <100.00%> (ø)
pkg/vct/proofmonitoring/monitoring.go 83.63% <0.00%> (-2.73%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc076da...22f6e4f. Read the comment docs.

@fqutishat fqutishat merged commit 4af7ab0 into trustbloc:main Jun 10, 2022
@bstasyszyn bstasyszyn deleted the 1329 branch June 10, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimized stores for config
3 participants