feat: Use multiple publisher pools if pool size is to large #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the pool size exceeds the maximum number of channels per connection then multiple publisher pools are created, each pool having a dedicated connection. The pools are distributed evenly. Also renamed startup parameter/environment variable from mq-max-connection-subscriptions/MQ_MAX_CONNECTION_SUBSCRIPTIONS to mq-max-connection-channels/MQ_MAX_CONNECTION_CHANNELS since it is used for publisher as well as subscriber pools. closes trustbloc#1372 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
fqutishat
approved these changes
Jun 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
+ Coverage 87.76% 87.82% +0.05%
==========================================
Files 199 200 +1
Lines 18595 18729 +134
==========================================
+ Hits 16320 16448 +128
- Misses 1461 1465 +4
- Partials 814 816 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pool size exceeds the maximum number of channels per connection then multiple publisher pools are created, each pool having a dedicated connection. The pools are distributed evenly.
Also renamed startup parameter/environment variable from mq-max-connection-subscriptions/MQ_MAX_CONNECTION_SUBSCRIPTIONS to mq-max-connection-channels/MQ_MAX_CONNECTION_CHANNELS since it is used for publisher as well as subscriber pools.
closes #1372
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com