Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return 200 in VCT health check if disabled or not yet configured #1384

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

bstasyszyn
Copy link
Contributor

If VCT is disabled or if the log endpoint has not yet been configured then the VCT health check does not cause the health check to fail, it simply returns the status of VCT.

closes #1360

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1384 (5e0ef43) into main (41ab9a7) will increase coverage by 0.01%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   87.94%   87.96%   +0.01%     
==========================================
  Files         205      205              
  Lines       19029    19047      +18     
==========================================
+ Hits        16735    16754      +19     
- Misses       1471     1472       +1     
+ Partials      823      821       -2     
Impacted Files Coverage Δ
pkg/config/client/client.go 89.18% <33.33%> (-6.27%) ⬇️
cmd/orb-server/startcmd/start.go 67.31% <50.00%> (-0.59%) ⬇️
pkg/discovery/endpoint/restapi/operations.go 88.21% <83.33%> (-0.31%) ⬇️
pkg/httpserver/server.go 87.30% <100.00%> (+10.10%) ⬆️
pkg/vct/vct.go 86.46% <100.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ab9a7...5e0ef43. Read the comment docs.

If VCT is disabled or if the log endpoint has not yet been configured then the VCT health check does not cause the health check to fail, it simply returns the status of VCT.

closes trustbloc#1360

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orb readiness probe
2 participants