feat: Add anchor and profile to anchor credential subject #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 88.08% 88.04% -0.05%
==========================================
Files 205 205
Lines 19092 19157 +65
==========================================
+ Hits 16818 16867 +49
- Misses 1459 1468 +9
- Partials 815 822 +7
Continue to review full report at Codecov.
|
bstasyszyn
force-pushed
the
1348
branch
3 times, most recently
from
d430707
to
590ed25
Compare
The credialSubject field in the anchor credential now has: - id - hashlink of the original content - anchor - the core index file hashlink - profile - the ID of the generator that generated the content When an anchor event is processed, the anchor credential subject is validated against the content. closes trustbloc#1348 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
sandrask
approved these changes
Jul 20, 2022
| @@ -139,6 +149,31 @@ func (h *AnchorEventHandler) HandleAnchorEvent(actor, anchorRef, source *url.URL | |||
| } | |||
|
|
|||
| func (h *AnchorEventHandler) processAnchorEvent(anchorInfo *anchorInfo) error { | |||
| anchorLink := anchorInfo.anchorLink | |||
There was a problem hiding this comment.
I am wondering if this code should have been in observer.go line 340 This is where we parse VC with checking signature.
There was a problem hiding this comment.
I added the checks in this spot since this is where anchor events from other domains are processed. The Observer also receives anchors from the local domain and these are assumed to be valid (since the local domain created it).
fqutishat
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The credialSubject field in the anchor credential now has:
When an anchor event is processed, the anchor credential subject is validated against the content.
closes #1348
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com